Update CScriptNetPropManager#541
Open
samisalreadytaken wants to merge 8 commits into
Open
Conversation
2 tasks
azzyr
requested changes
Jun 4, 2026
| @@ -1249,19 +1289,21 @@ class CScriptNetPropManager | |||
| if ( pInfo->datatype == types::_VEC3 ) | |||
| arraysize *= 3; | |||
|
|
|||
| if ( index < 0 || (unsigned int)index >= arraysize ) | |||
| if ( (unsigned int)index >= arraysize ) | |||
Collaborator
There was a problem hiding this comment.
is there a particular reason for removing these lower bound checks? index is provided by the user so this seems scary
Author
There was a problem hiding this comment.
Unsigned cast of all negative numbers ([-1, -2147483648] -> [2147483648, 4294967295]) is always larger than the limit. It compiles into same code with less instructions (0-test) because arraysize is always non-zero.
If, on 64-bit, this function were to take a 64-bit signed index and this unsigned cast stayed 32-bit, values in the range [0x8000000000000000, 0x800000007fffffff] would truncate the sign bit and access out of bounds, but that's a lot of unlikely ifs.
I added some more assertions and a comment to inform future editors. This isn't a super important change though, impact of these 2 instructions is negligible
samisalreadytaken
force-pushed
the
netprops
branch
from
974f53e to
56c4502
Compare
azzyr
approved these changes
Jun 5, 2026
samisalreadytaken
force-pushed
the
netprops
branch
3 times, most recently
from
5034ee8 to
dbbb73c
Compare
Author
|
Also added support for reading output values. Use the following regex to find all variables that are now possible to get: Script-only demo: local game_globalvars = SpawnEntityFromTable( "game_globalvars", null );
game_globalvars.AcceptInput( "GetCurtime", "", null, null );
assert( NetProps.GetPropFloat( game_globalvars, "m_OutCurtime" ) == Time() );
assert( NetProps.GetPropInt( game_globalvars, "m_OutCurtime" ) == -1 );
local math_vector = SpawnEntityFromTable( "math_vector", null );
math_vector.AcceptInput( "SetValue", "1 2 3", null, null );
assert( NetProps.GetPropVector( math_vector, "m_OutValue" ).IsEqualTo( Vector(1, 2, 3) ) );
assert( NetProps.GetPropFloat( math_vector, "m_OutY" ) == 2.0 );
local logic_substring = SpawnEntityFromTable( "logic_substring", null );
logic_substring.AcceptInput( "SetStartPos", "6", null, null );
logic_substring.AcceptInput( "SetLength", "5", null, null );
logic_substring.AcceptInput( "InValue", "yberz vcfhz qbybe", null, null );
assert( NetProps.GetPropString( logic_substring, "m_OutValue" ) == "vcfhz" );
local logic_playerinfo = SpawnEntityFromTable( "logic_playerinfo", null );
logic_playerinfo.AcceptInput( "GetPlayerInfo", "", null, null );
assert( NetProps.GetPropEntity( logic_playerinfo, "m_OutPlayerEntity" ) == Entities.GetLocalPlayer() );
print("done\n");Some more useful examples: local ent = Entities.FindByClassname( null, "npc_grenade_frag" );
ent.ConnectOutput( "OnDetonate_OutPosition", "OnDetonate_OutPosition" );
ent.GetOrCreatePrivateScriptScope().OnDetonate_OutPosition <- function()
{
local pos = NetProps.GetPropVector( self, "m_OnDetonate_OutPosition" );
printl( "OnDetonate_OutPosition " + pos );
}local ent = Entities.FindByClassname( null, "env_microphone" );
ent.ConnectOutput( "SoundLevel", "SoundLevel" );
ent.GetOrCreatePrivateScriptScope().SoundLevel <- function()
{
local volume = NetProps.GetPropFloat( self, "m_SoundLevel" );
printl( "SoundLevel " + volume );
}local ent = Entities.FindByClassname( null, "ai_goal_actbusy" );
ent.ConnectOutput( "OnNPCStartedBusy", "OnNPCStartedBusy" );
ent.ConnectOutput( "OnNPCSeeEnemy", "OnNPCSeeEnemy" );
ent.GetOrCreatePrivateScriptScope().OnNPCStartedBusy <- function()
{
local npc = NetProps.GetPropEntity( self, "m_OnNPCStartedBusy" );
printl( "OnNPCStartedBusy " + npc );
}
ent.GetOrCreatePrivateScriptScope().OnNPCSeeEnemy <- function()
{
local npc = NetProps.GetPropEntity( self, "m_OnNPCSeeEnemy" );
printl( "OnNPCSeeEnemy " + npc );
}local ent = player;
ent.ConnectOutput( "OnKilledEnemy", "OnKilledEnemy" );
ent.GetOrCreatePrivateScriptScope().OnKilledEnemy <- function()
{
local victim = NetProps.GetPropEntity( self, "m_OnKilledEnemy" );
printl( "OnKilledEnemy " + victim );
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning message is quite important, it's easy to make typos and not be aware of it ever.
Fixes tf2classified/tf2classified-issue-tracker#485
PR Checklist
developbranch OR targets another branch with a specific goal in mind